Required Billing Fields

Question

Required Billing Fields

Opened this issue 10 years ago · 6 comments

I'm using your library for validating orders processed via PayPal and therefore I don't have any billing information.

I've talked to MaxMind and they told me I can continue without the billing data.
Why did you mark the billing as required fields?

Can you please mark the billing fields as not required and push an update?

Answer 1 · 2015-03-03T19:13:54.000Z

Good catch, I was with the understanding this was a required field. I'll review and update as appropriate.

Answer 2 · 2015-03-03T19:15:11.000Z

thanks for your fast reply.
I will update and verify that your fix works.

On Tue, Mar 3, 2015 at 9:13 PM, Joshua D. Burns notifications@github.com
wrote:

Good catch, I was with the understanding this was a required field. I'll
review and update as appropriate.

—
Reply to this email directly or view it on GitHub
#3 (comment).

Answer 3 · 2015-03-03T19:19:04.000Z

Fixed, change was made in pyminfraud/fields.py.

Answer 4 · 2015-03-03T19:19:56.000Z

did you update git?
why don't you support pip?

On Tue, Mar 3, 2015 at 9:19 PM, Joshua D. Burns notifications@github.com
wrote:

Fixed, change was made in pyminfraud/fields.py.

—
Reply to this email directly or view it on GitHub
#3 (comment).

Answer 5 · 2015-03-03T19:37:31.000Z

Yes, updated in Git.
I thought I had support for pip working at one time, but I see it's broken now.. I'll re-visit when I get a chance.

Answer 6 · 2015-03-03T19:38:32.000Z

thanks, just updated, will keep you posted

On Tue, Mar 3, 2015 at 9:37 PM, Joshua D. Burns notifications@github.com
wrote:

Yes, updated in Git.
I thought I had support for pip working at one time, but I see it's broken
now.. I'll re-visit when I get a chance.

—
Reply to this email directly or view it on GitHub
#3 (comment).