Suggested fix for Acknowledgements page Sidebar links getting 404s

jerryg2003 opened this issue 3 years ago · 5 comments

jerryg2003 commented 3 years ago

See JMRI Issue #9837. help/en/Acknowledgements.shtml in the JMRI repository points to /Sidebar.shtml in the web repository. /Sidebar.shtml in this repository has all the links set up with an initial "./"

If I remove the "." then the Acknowledgements.shtml links will work. But are there any other (negative) ramifications of this change?

Thanks.

Answer 1 · 2021-07-12T22:03:41.000Z

@silverailscolo @dsand47
I mention you to notify you about this issue in case you haven't seen it already.

Answer 2 · 2021-07-12T22:36:30.000Z

How about using the html sidebar for acknowledgments.

    <!--#include virtual="html/Sidebar.shtml" --> <!-- might be improved to show an Alphabet sidebar + some nav? -->

Another approach would be to create a sidebar at help/en for use by acknowledgments.

Answer 3 · 2021-07-13T02:27:00.000Z

I've been trying for a couple of years to reduce the number of different sidebars unless really necessary, so I'll just change to use the html/Sidebar.shtml. Thanks.

Answer 4 · 2021-07-17T23:22:02.000Z

Suggestions have been made in the JMRI/JMRI pull request #9960 about improving navigation for the acknowledgements page. Given that we haven’t yet agreed on whether or what to implement, I have submitted PR #433 to at least users won’t get broken links on the sidebar from the acknowledgements page.

Answer 5 · 2021-08-23T03:50:56.000Z

Resolved by putting new Sidebar into html directory in JMRI/JMRI repository.