double click bug
Stefal opened this issue · 6 comments
Hi,
With the latest release 1.5.21, Josm 16239, 1.8.0_191-b12, Windows 10, if you have a selected image, and you double click anyhere on the active osm layer, it removes the image from the viewer.
This was actually by design, so that the current image and image sequence would be deselected. Do you have an alternative method to deselect the current image and image sequence?
If it makes sense, I'm open to doing it (may be awhile -- depends upon other time commitments), or taking pull requests.
Commit: 587eef4
Is it a useful feature to deselect an image/sequence ?
Double click is already a Josm mouse "shortcut" to select the enclosing area, so I don't think it's a good idea to reuse it for another feature on an unselected layer.
I did know that it was a JOSM mouse shortcut. I also know that OpenStreetCam requires more clicks, but it has always been semi-broken for me.
I'll make a build that requires three clicks, and you can get back to me if that works well for deselecting the sequence. I'll be able to test later myself.
I also added a preference key (mapillary.image.deselect.click.count) that you can change in advanced preferences if you don't like 3 as the click count. This is an unreleased version.
Mapillary.jar.zip
You will have to remove the .zip and place it in the JOSM plugin directory.
I'm closing this, since you can now set the click count in advanced preferences, and it defaults to a triple-click.
Does it work? Just tried this version setting mapillary.image.deselect.click.count to 2,3,4, the image always disappears after double click. Tried restarting.
Yes. I did make a mistake in the initial patch, but it is fixed now (in an unreleased branch).
Sorry about that.
(See https://gitlab.com/gokaart/josm-mapillary-plugin/-/commit/21642ec0d47d499027ddf9a943aad9c323b37b1c )