JPLogistics/JPLogistics_C152

Regular and Fairing version seem to have differences they shouldn't have

Havner opened this issue · 5 comments

Havner commented

Hi, out of curiosity I diffed the 2 versions and found some differences I think there shouldn't be there. As if e.g. some flight dynamic changes were made to one version, but the other got forgotten.

I've attached a filtered (removed big changes that are normal, like model, etc) diff with a regular text changes left. In the attached file only 3 struck me as logical:

  • the gear drag
  • cruise speed
  • name and liveries

But the rest doesn't look right.
There are things from formatting inconsistencies up to different drag for flaps, AI changes, prop animation differences.
Some things seem to come from Asobo updates (like effects, fairing version seem to be based on newer revision).

Some are even more strange like CIRCUIT_LIGHT_PANEL with diametrically different values. Also default_pitch_mode, but I don't know that that does.

Maybe it would be a good idea to unify that?
I could do that if you have little time and send you a pull request, but I'd need few questions answered because I don't know which variant is correct.

weptburrito commented

ahh....ooops? That's my fault. Forgetting to apply changes to the other plane. Thanks!!! Fixing it now.

Havner commented

:-)

Also some leftovers can be removed, like:
jplogistics-c152/SimObjects/Airplanes/JPL_C152/flight_model.cfgold

weptburrito commented

Maybe ;) some “old” files are left as we test things so we can easily revert if necessary.

It used to be a lot neater as we had the released version and the dev version. But SU5 really messed things up and left us scrambling to completely redo the mod from scratch. So updates at this point are really the dev version which is why it’s labeled as a beta. SU6 is reportedly breaking some things again too.

But, we should be getting things back to normal soon and the released versions will be a lot more stable.

Havner commented

Ok :-)

Now that you are aware I'll wait for your updates then. When I find something a little inconsistent in the future I'll just send a pull request to clean things up instead of reporting similar issues.

Thanks for the mod, love it.