JaGeo/LobsterPy

Update workflows

Closed this issue · 4 comments

JaGeo commented

Describe the bug
Tests seem to fail. They worked for the pull request but failed afterwards, @naik-aakash .

naik-aakash commented

Hi Janine, thanks for this issue. So I think the problem is Black is not in pylint workflow, but I have added this check in pre-commit config. If pre-commit is used before pushing any commits, this should not happen in the future. Maybe I can write this in the README file as well on how to contribute.

I will add black runs in the pylint workflow as well and raise a PR for the updated pylint workflow. Sorry for the inconvenience

JaGeo commented

Could you make the precommit part of the workflow so that we don't run into this issue anymore?

  • 👍1
naik-aakash commented

Sure. I will have a look at how to do it. Should be fairly quick, I think

naik-aakash commented

Btw, and I am not sure why Pylint did not run on the PR ( #107 ) raised in the first place. It just seems to have run only the test workflow (Thus, all tests seemed to pass). Pylint runs for me always on my repo, so all linitng checks are run on the code, and all the issues are raised if any exist on each commit and then could be solved.

I think I need to check a bit more in detail why did this happen.

  • 👍1