Jagusti/fvtt-wfrp4e-gmtoolkit

Add FVTT Version 10 Compatibility

Jagusti opened this issue · 5 comments

Jagusti commented

This issue tracks scope and progress of functional compatibility with Foundry VTT v10.277 and WFRP4e v6.0.0.9.

  • The aim is to eliminate breaking errors and minimise warnings to get a working version of the GM Toolkit ready with minimal delay.
  • For non-breaking changes, some refactoring may be carried out as part of this migration to leverage new v10 patterns and models.
  • Any significant enhancements (eg, vision modes) or extensive rewriting will be deferred until after compatibility tasks are completed.

Reference: https://foundryvtt.com/article/migration/

Key for list below:

  • commit link to related commit / pr
  • 9️⃣ no change made for compatibility

Module

  • Manifest (id, relationships, compatibility) 8d679ca
  • Initialisation 9️⃣
  • Settings
    • scripts 9️⃣
    • templates 9️⃣
    • debouncedReload 7c20c11
  • #161

Macros

Scripts

  • Add Advantage 9️⃣
  • Clear Advantage 9️⃣
  • Reduce Advantage 9️⃣
  • Check Conditions c9eb364
  • Session Turnover 9️⃣
  • Add XP 9️⃣
  • Reset Fortune e9b6842
  • Make Secret Group Test
  • Send Dark Whispers c54bd3a
  • Toggle Scene Visibility and Light 383ccc5
  • Set Token Vision and Light 881658
  • Pull Everyone to Scene 4334a28
  • Simply d100 9️⃣
  • GM Toolbox 78f3ff9
  • Toggle Compendium Pack Visibility 9️⃣

Package

RollTable

  • Dark Whispers
  • RollTable Compendium dddbe4f

Features

  • Toolkit Maintenance (script, template) 5713431 dddbe4f
  • Token Hud Extension (module) b016b6
  • Dark Whispers (module, macro, table) c54bd3a
  • Advantage (module, macros)
    • Assisted Advantage handling f4b6738
      • Personal Advantage
      • Context: macro
      • Group Advantage
      • Adding to combat
      • Removing from combat
    • Advanced automation fb83fb7
      • Context: Outmanoeuvring
      • Context: Winning Opposed Tests
      • Context: Advantage Flags
      • Socket Handling
      • Lose Momentum f27889e
      • Condition Effects 0a85244
  • Group Test (module, script, template) 20febde

Helpers

Other

  • Spectator Notification e1cfddd
  • Holding Scene Token Movement f6da3ac
  • Stylesheet
    • Token Hud Extension

Documentation

  • Readme
  • Changelog
  • Wiki
bluetardis commented

Let me know if/when you want help with testing!

  • 👍1
Jagusti commented

The Dark Whispers table seems to be doing what it needs to in the context of the Send Dark Whispers macro. There is some strange behaviour when accessing the Rolltable directly, which appears to be a system template issue: moo-man/WFRP4e-FoundryVTT#1200.

Jagusti commented

Launching a Skill Test from the Token Hud presents the roll dialog as expected and without user alert. However, there are multiple console warnings raised as part of the test setup for trying to access the Hit Location tables TableResult#data object. This will need to be resolved at a system level. Toolkit behaviour is essentially unaffected, but the console is spammed with compatibility and deprecation warnings.

commons.js:1232 Error: You are accessing the TableResult#data object which is no longer used. Since V10 the Document class and its contained DataModel are merged into a combined data structure. You should now reference keys which were previously contained within the data object directly.
    at logCompatibilityWarning (commons.js:1221:19)
    at TableResult._logV10CompatibilityWarning (commons.js:6058:14)
    at get data [as data] (commons.js:5958:24)
    at wfrp4e.js:131:22
    at EmbeddedCollection.forEach (commons.js:2748:9)
    at WFRP_Tables.getHitLocTable (wfrp4e.js:130:23)
    at ActorWfrp4e.setupSkill (wfrp4e.js:8957:46)
    at HTMLElement.<anonymous> (token-hud-extension.mjs:111:17)
    at HTMLElement.dispatch (jquery.min.js:2:43064)
    at v.handle (jquery.min.js:2:41048)

I've submitted a PR to address some of the issues I've come across: moo-man/WFRP4e-FoundryVTT#1201

Jagusti commented

Make Secret Group Test breaks on FVTT 10.277 because of foundryvtt/foundryvtt#7819. Once this is shipped I'll pick this up again.

Jagusti commented

Nearly a wrap ... some version admin to do, and maybe publish a release candidate. But this is testable from the v10 branch: https://github.com/Jagusti/fvtt-wfrp4e-gmtoolkit/tree/v10.