Jahaja/psdash

PSDASH_LOGS in config.py file are not taken into account.

n3storm opened this issue · 3 comments

I had a look to code and seems like overwriting config is messed from my point of view.

psdash/run.py line 203

    def _setup_context(self):
        self.get_local_node().net_io_counters.update()
        if 'PSDASH_LOGS' in self.app.config:
            self.get_local_node().logs.add_patterns(self.app.config['PSDASH_LOGS'])

Seems to me that at this point self.app.config has already been overwritten by some default values, that is why if I print self.app.config['PSDASH_LOGS']) is always an empty list [], also,

if 'PSDASH_LOGS' in self.app.config:

evaluates always to True.

Don't know how to fix it or better, what is the expected overwritting strategy.

Cheers

Good find, thanks. I think I found what the cause is and I'll fix it later today.

Forget about line 203 at run.py. It all starts (as you already may have guessed) at line 52 default=[], sorry for that.

Thanks for your quick response!

Fixed in f20fa76.