JakePartusch/lumberjack

"Cannot navigate to invalid URL" when having special characters in the URL

Opened this issue · 3 comments

When having umlauts or other special characters, lumberjack fails with the message:

Protocol error (Page.navigate): Cannot navigate to invalid URL

Steps to reproduce:

  • Invoke lumberjack --url https://velo.rent

I think that the problem here is that the sitemap has relative URLs. With that being said, I'm not able to find a definitive source on whether or not relative URLs in a sitemap are valid or not... 🤷‍♂

If relative URLs are indeed a valid/common use-case, I definitely think we should support 👍

I actually don't know either, but the sitemap was generated by the default Hugo template, so I assume they are valid. :D

Ok cool. @jlnostr, If you want to take a stab at a fix, that would be awesome! 🎉

Otherwise, I'll get around to it soon-ish