JakeWharton/u2020

Move SDK version details from AndroidManifest.xml to gradle

danielkutik opened this issue · 2 comments

danielkutik commented

Personally I prefer to keep all these version numbers and so on outside of the AndroidManifest.xml and hence would suggest to move

src/main/AndroidManifest.xml(line 7):

<uses-sdk
      android:minSdkVersion="14"
      android:targetSdkVersion="19"/>

into build.gradle(line 60)

defaultConfig {
    ...
    minSdkVersion 14
    targetSdkVersion 19

What do you think?

JakeWharton commented

I really don't care either way. Send me a PR for it!