JakkuSakura/kafcat

implement integration testing and CI/CD

Opened this issue · 5 comments

As suggested, there should be some kind of testing and CI/CD. My approach is to setup a kafka docker image and write a bunch of tests, like what kafkacat does.

For CI/CD, I have little experiences on them, but it should not be hard once we have docker-based tests.

hbina commented

Why not use Github Actions?

It looks like the github actions workflow didn't run well. I would like to draft a pr to fix it :)

Screen Shot 2022-04-14 at 6 37 33 PM

Screen Shot 2022-04-14 at 6 39 21 PM

@qiujiangkun Hi, please place a branch protection rule, and add tests into the checks. So that every pr would be required to pass the CI before merging.

image

I set up such rules

Thanks for your quick response! Let me fix the CI.