download_catch_rates() creates values for "num" when add_zeros = TRUE

[andrewdeines]

For example

DF = FishData::download_catch_rates(survey="West_coast_groundfish_bottom_trawl_survey", species_set="Platymera gaudichaudii")
head(DF[DF$Year==2003 & DF$Wt==0 & !is.na(DF$Num), ])

[Lewis-Barnett-NOAA]

The problem does not seem to be with add_zeros, because the numbers (abundance) does not match the values in the data warehouse even when add_zeros = FALSE. The problem is that the area swept column in the query no longer exists in the catch records database in the data warehouse. It does still exist in the haul information database, but that would have to be queried separately and then joined to the catch information by the haul identifier.

[James-Thorson]

I'm not following and don't have time to give input. You could just put NAs for the counts for WCGBTS? Really we should prolly just ask John Wallace if he'd maintain NWFSC repository interfacing code for this package

…

On Wed, Aug 8, 2018, 11:48 AM lewisab ***@***.***> wrote: Well, it appears that the area swept column is still in the haul information, so if that is getting extracted correctly then the problem is with this term which is multiplied by the CPUE in the attempt to obtain the raw catch and area swept as separate columns: outer(Downloaded_data[,'area_swept_ha_der'],c(1,1)) Maybe it should be: outer(Downloaded_data['area_swept_ha_der'],c(1,1)) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHnqTVj9nWykZjLqtBaQGahtChrD7kQ6ks5uOzJ8gaJpZM4VMWOg> .

[James-Thorson]

solved by listing counts as NA in latest commit.