Update Node from 10 to 12

Question

Update Node from 10 to 12

JamesIves opened this issue 4 years ago · 8 comments

Describe the bug

Right now the .nvmrc file points to Node 10. This is two versions out of date and should be updated to use the latest Node version.

Additional Comments

Change the node version, install with nvm use.
Run the usual commands, yarn install, yarn format, yarn lint, yarn test. Ensure there are no issues.
Make applicable readme and fixes to ensure it's clear to the user that this action runs on Node 12+.

Answer 1 · 2020-10-02T13:14:44.000Z

@JamesIves . Would like to work on this issue

Answer 2 · 2020-10-02T13:21:46.000Z

Go for it! I've assigned it to you.

Answer 3 · 2020-10-02T14:30:54.000Z

After the suggested changes.,

No issues with yarn test
Fixed issues with yarn lint
yarn format have few errors. @JamesIves . Need you suggestion how to resolve this.

Answer 4 · 2020-10-02T14:46:42.000Z

Are you using Mac/Linux or Windows?

Answer 5 · 2020-10-02T14:49:04.000Z

Windows 10 with Node version 12.8.4

Answer 6 · 2020-10-02T14:55:21.000Z

This is probably due to the use of single quotes in the format command. Try wrapping the pattern in the format command with double quotes instead?

I'm not a Windows user personally so I'm unsure.

Answer 7 · 2020-10-02T15:23:05.000Z

This is probably due to the use of single quotes in the format command. Try wrapping the pattern in the format command with double quotes instead?

I'm not a Windows user personally so I'm unsure.

Thanks @JamesIves . The suggestion you gave worked out. Raised the PR, would like to review

Answer 8 · 2020-10-03T00:25:46.000Z

Approved/merged. Thanks for doing that!