JamesOwers/midi_degradation_toolkit

data_structures.read_note_csv cannot read our own CSVs

apmcleod opened this issue · 1 comments

Here: https://github.com/JamesOwers/midi_degradation_toolkit/blob/master/mdtk/data_structures.py#L26

Currently, I cannot read our own csvs with it. With no args, or with header=None, I get this:

ValueError: Usecols do not match columns, columns expected but not found: ['dur', 'onset', 'track', 'pitch']

There is a lot of extra functionality included to be able to parse various formats of csvs I think, but IMO, a lot of these just add complications that make it more difficult to figure out how to use (for example, it took me a while to figure out the different params after not using it for some time). This function should maybe just be a function to parse our own CSVs, with some very basic arguments (sort, monophonic, etc), but not as much all of the formatting.

At least, calling it with no args should parse our own csvs.

Somewhat related to #104