JanStevens/angular-growl-2

Feature request: Return the configuration object on config methods

Closed this issue · 3 comments

Right now I'm setting the global configuration as this:

  growlProvider.globalTimeToLive(5000);
  growlProvider.globalDisableIcons(true);

which reads awfully.

When doing:

  growlProvider
            .globalTimeToLive(5000)
            .globalDisableIcons(true);

It is triggering the following error:

growlProvider.globalTimeToLive(...) is undefined

so it appears it is not retuning the growlProvider instance.

Can this be added so we can chain config setters?

Sure feel free to add a PR!

I'm on that right now :)

One question, though, should I have to build the library before submitting the PR?

Any updates on this?