JanStevens/angular-growl-2

Error in IE8 closing messages

Closed this issue · 5 comments

Getting "TypeError: Object doesn't support this property or method" errors when closing messages.

I fixed it by replacing line 409 with the following:
var messages = this.getAllMessages(message.referenceId), index = -1;

for (var i in messages) index = (messages[i] == message) ? i : index;

Please submit a PR for this fix

For some reason I can't create a new branch. Emailed Github, awaiting reply.

You do not have push permissions to this repo. Please fork the repo, and make your changes on your own account, then submit a PR from your fork

Well that's what I first tried, but every time I tried to "fork" (using the top-right button), it forks the old "marcorinck/angular-growl" project. Sorry completely new to this thing :)

Managed to create pull request... please check