deletes and merges not updated in template similarity score plot

Question

deletes and merges not updated in template similarity score plot

agbondy opened this issue 5 years ago · 6 comments

When a cluster is deleted or two are merged, this is not updated in the template similarity score plot. Therefore the indices of this plot are no longer accurate after a merge or delete operation, making it unusable. This seems to be a bug introduced rather recently.

Answer 1 · 2019-08-26T19:19:02.000Z

I temporarily fixed this in a hacky way by forcing the code to always enter the first conditional statement in +jrclust+sort@TemplateClustering\commit. That is, if we force the code block starting at line 7 instead of the code block starting at line 26, the plot updates fine.

Answer 2 · 2019-08-27T14:24:13.000Z

Hey @agbondy what's the commit hash of the version you're running?

Answer 3 · 2019-08-27T17:28:03.000Z

I am running my own fork but it is up to date with all commits in the main branch. My own changes are to do with the appearance of figures, and none are related to the updating of the template similarity scores.

Answer 4 · 2019-08-27T17:43:25.000Z

Mistake on my end, I hadn't updated the repo on the machine I'm working on. I see what you're talking about now. Let me take a look.

Answer 5 · 2019-08-27T18:42:40.000Z

Works for me now. Give the latest a merge and see if that works for you.

Answer 6 · 2019-08-27T20:53:11.000Z

Yup it's working now. Thanks!