Bool32 sometimes very difficult to use
Opened this issue · 1 comments
pjabardo commented
Bool32 is defined as a 32 bit primitive but no methods of any kind are available so some functions that use this argument are difficult to use. Is there a specific reason for this? Couldn't Bool32 be defined as a Int32?
Replace the line in NIDAQ.jl
primitive type Bool32<:Integer 32 end
with
const Bool32 = Int32
Paulo
bjarthur commented
huh. good point. i don't remember the reason for that. have you tried it yourself and everything works? happy to review a PR. you'd want to make changes in these two places too:
https://github.com/JaneliaSciComp/NIDAQ.jl/blob/master/src/constants_V20.1.0.jl#L3685
https://github.com/JaneliaSciComp/NIDAQ.jl/blob/master/README.md?plain=1#L406