JaneliaSciComp/bigstream

adding option to not gaussian filter transforms in motion_correct

vruetten opened this issue · 2 comments

Hey Greg,

Thanks for the great repo!

When using the pipeline to register functional data, we expect the transforms to have occasional large deltas (when the live specimen tries to move). Under such circumstances, smoothing the transform with a Gaussian filter does more harm than good. I can set the sigma to be very small but that feels suboptimal - a median filter would be more fitting for this case, or simply the option to have no filtering at all.
I think this is where it is hard coded:
https://github.com/GFleishman/bigstream/blob/f8f003e483fb3e31c9601f8a643a94af524343ea/bigstream/motion_correct.py#L180

Would it be possible to expose this option to users when you have a second? (or tell me that I've missed an existing functionality :) ).

Thanks in advance!

Best,

Ginny

Hi Ginny,

I definitely agree, there should be multiple options for smoothing over time (including no smoothing) exposed to the user. I’m preparing for a two week trip and won’t be programming until I get back. I’m happy to add this when I’m back or if you’re motivated I’d also be happy to review and merge a pull request.

I believe Ginny closed this issue with a PR - thanks very much @vruetten !