JaseZiv/worldfootballR

tm_team_player_urls() returning www.transfermarkt.com instead of player urls.

wernerholzapfel opened this issue · 3 comments

When I run
tm_team_player_urls(team_url = "https://www.transfermarkt.com/fc-burnley/startseite/verein/1132/saison_id/2023")

I get:

tm_team_player_urls(team_url = "https://www.transfermarkt.com/fc-burnley/startseite/verein/1132/saison_id/2023")
[1] "https://www.transfermarkt.com"

Instead of a list of player urls for burnley... doesn't work for other teams either

This is likely because you're using an older version of worldfootballR.

I tested on version 0.6.4.0001 and returned the expected results:

players <- worldfootballR::tm_team_player_urls(team_url = "https://www.transfermarkt.com/fc-burnley/startseite/verein/1132/saison_id/2023")
players

# [1] "https://www.transfermarkt.com/james-trafford/profil/spieler/566799"        
# [2] "https://www.transfermarkt.com/arijanet-muric/profil/spieler/371021"        
# [3] "https://www.transfermarkt.com/lawrence-vigouroux/profil/spieler/243591"    
# [4] "https://www.transfermarkt.com/denis-franchi/profil/spieler/606576"         
# [5] "https://www.transfermarkt.com/jordan-beyer/profil/spieler/403898"          
# [6] "https://www.transfermarkt.com/hjalmar-ekdal/profil/spieler/392179"         
# [7] "https://www.transfermarkt.com/ameen-al-dakhil/profil/spieler/620598"       
# [8] "https://www.transfermarkt.com/dara-oshea/profil/spieler/401320"            
# [9] "https://www.transfermarkt.com/cj-egan-riley/profil/spieler/581669"         
# [10] "https://www.transfermarkt.com/hannes-delcroix/profil/spieler/338635"       
# [11] "https://www.transfermarkt.com/charlie-taylor/profil/spieler/195633"        
# [12] "https://www.transfermarkt.com/connor-roberts/profil/spieler/214666"        
# [13] "https://www.transfermarkt.com/vitinho/profil/spieler/468249"               
# [14] "https://www.transfermarkt.com/sander-berge/profil/spieler/333014"          
# [15] "https://www.transfermarkt.com/jack-cork/profil/spieler/40613"              
# [16] "https://www.transfermarkt.com/josh-brownhill/profil/spieler/293569"        
# [17] "https://www.transfermarkt.com/josh-cullen/profil/spieler/242606"           
# [18] "https://www.transfermarkt.com/samuel-bastien/profil/spieler/289510"        
# [19] "https://www.transfermarkt.com/aaron-ramsey/profil/spieler/646658"          
# [20] "https://www.transfermarkt.com/anass-zaroury/profil/spieler/491296"         
# [21] "https://www.transfermarkt.com/jacob-bruun-larsen/profil/spieler/293281"    
# [22] "https://www.transfermarkt.com/darko-churlinov/profil/spieler/386786"       
# [23] "https://www.transfermarkt.com/nathan-redmond/profil/spieler/129078"        
# [24] "https://www.transfermarkt.com/manuel-benson/profil/spieler/322702"         
# [25] "https://www.transfermarkt.com/wilson-odobert/profil/spieler/743498"        
# [26] "https://www.transfermarkt.com/johann-berg-gudmundsson/profil/spieler/89231"
# [27] "https://www.transfermarkt.com/luca-koleosho/profil/spieler/745461"         
# [28] "https://www.transfermarkt.com/enock-agyei/profil/spieler/724041"           
# [29] "https://www.transfermarkt.com/zeki-amdouni/profil/spieler/548729"          
# [30] "https://www.transfermarkt.com/lyle-foster/profil/spieler/467623"           
# [31] "https://www.transfermarkt.com/michael-obafemi/profil/spieler/444208"       
# [32] "https://www.transfermarkt.com/jay-rodriguez/profil/spieler/53360" 

I'm using the CRAN version
https://cran.r-project.org/web/packages/worldfootballR/index.html which is still on 0.6.2

I'm using the CRAN version

https://cran.r-project.org/web/packages/worldfootballR/index.html which is still on 0.6.2

You will need to install the latest dev version for this to work.

The latest version though no longer contains fotmob functions so beware if you need them.

I will close this issue now.