Jasonette/documentation

header option for $network.request action not working

Opened this issue · 2 comments

amankumarjain commented

{ "type": "$network.request", "options": { "url": "http://www.jasonbase.com/messages.json", "method": "post", "data": { "user_id": "fI9", "message": "Hello there" }, "header": { "auth_token": "fnekfla98dls9sNFK0nf3" } }, "success": { "type": "$render" }, "error": { "type": "$util.alert", "options": { "title": "Error", "description": "Uh oh, something went wrong" } } }

In the previous code, if we pass header with this request, it doesnot add header.
Android File: JasonNetworkAction, header option condition is not handelled.

can i do pull request to patch this issue?

gliechtenstein commented

This should be fixed with the latest develop branch. Could you retry and let me know if that works? You can get it here https://github.com/Jasonette/JASONETTE-Android/archive/develop.zip

  • 👍1
gliechtenstein commented

Oh i had totally missed the part where you asked if you can do a pull request.

This time I just went ahead and fixed it, but in the future please feel free to send a PR anytime if you see something wrong. Totally appreciate it!

  • 👍1