Wrong season retrieved ...
Opened this issue · 1 comments
sensorario commented
Season is wrongly retrieved: updating dataProvider of ::testDateParsing I found this Bug. Please consider to fix it or, ... just wait my next PR. ^_^
/**
* @dataProvider dateStrings
*/
public function testDateParsing($original, $expected)
{
$result = $this->season->get($original);
$this->assertEquals($expected, $result);
}
public function dateStrings()
{
return array(
array('20st March', Seasons::SEASON_SUMMER),
array('20st June', Seasons::SEASON_AUTUMN),
array('22st September', Seasons::SEASON_WINTER),
array('20st December', Seasons::SEASON_SPRING),
array('1st June', Seasons::SEASON_SUMMER),
array('1st October 2016', Seasons::SEASON_AUTUMN),
array('31st December', Seasons::SEASON_WINTER),
);
}
strarsis commented
@sensorario: Have you made a PR for this? Has it been merged since then?
JayBizzle: Has this been fixed since then?