JeroenDeDauw/GitHub

Support markdown rendering

Closed this issue · 10 comments

kghbln commented

I have included the installation documentation for SMW on smw.o using the "github" parser function like described in the README ({{#github:docs/INSTALL.md}}). However the rendering of the embedded page's content is incorrect. Probably a change in MW 1.22 broke this. It will be cool if you had a peep at this issue.

[1] https://semantic-mediawiki.org/wiki/User:Kghbln/test

JeroenDeDauw commented

This is because the file you are pointing to is not written in wikitext format. So this is not really a bug. You can however turn this into a feature request for supporting markdown.

kghbln commented

Ah, didn't we have the same issue with the "Gitweb" extension? So yes, if Markdown needs to be supported, this would then be a feature request.:)

JeroenDeDauw commented

We did not have that issue as at that time our docs where in wikitext.

kghbln commented

Really must have been different back then. Thanks for turning this into a feature request. Should still be labelled as an enhancement which I cannot do.

JeroenDeDauw commented

Meh. I really do not want to copy the rel notes to SMW wiki... Rather try to implement this now :)

JeroenDeDauw commented

Markdown parsing has been implemented on master. Wikitext parsing is no longer implemented though :) Something that can only be re-added nicely if I poke a bit at the ParserHooks library.

kghbln commented

That's really awesome. Yeah, this was a must-do feature since GitHub basically forces one to use Markdown. I do not know if it is necessary to re-implement the wikitext rendering.

JeroenDeDauw commented

GitHub basically forces one to use Markdown

Nope. It also supports other formats, including wikitext. Markdown is the standard though.

I do not know if it is necessary to re-implement the wikitext rendering.

Yeah, it is not needed for our use case, so I'm not bothering for now.

kghbln commented

GitHub just constantly asks for a README.md :)