Jeryn99/Regeneration

[1.20.1] Issue with PlayerRevive mod

Closed this issue · 3 comments

CreativeMD commented

Issue description

Hey,
I'm the creator of PlayerRevive and there seems to be a few issues with your mod.
Video

Seems like the player gets down twice. PlayerRevive works quite simple, it listens to the LivingDeathEvent and cancels it. Once the player has bled out it will trigger the death again. There is a list of damage sources which bypass this system and make the player die instant. Maybe this could solve the issue of the player being downed.

Maybe you got an idea why this is happening? Otherwise would be cool if you can explain how your system works and then we might be able to figure out what is going wrong.

In Regards
CreativeMD

Steps to reproduce

  1. Install PlayerRevive
  2. Die

Minecraft version

1.20.1

Mod Loader Platform type

Forge

Mod Loader version

1.20.1 - 47.2.19

Mod version

v42.0.0

Jeryn99 commented

Hello, this class should somewhat walk through everything related to death for forge: https://github.com/Suff99/Regeneration/blob/architectury/1.19.2/forge/src/main/java/mc/craig/software/regen/forge/handlers/CommonEvents.java

I apologize, the codebase has been a bit of a mess due to being ported all the way from 1.12 with different levels of understanding of programming. I plan to redo this mod at some point

CreativeMD commented

Can you explain in words what your mod does? Because I'm quite confused the player gets downed a second time. Does the player receive any kind of damage when regenerating?

github-actions commented

This issue has been marked as stale due to inactivity. If this is still a relevant issue, please comment or take action to prevent it from being closed.