JetBrains-Research/reflekt

Add ktlint in the project

nbirillo opened this issue · 5 comments

nbirillo commented

Add ktlint and fix all code quality issues if it is necessary

orchestr7 commented

I was actually impressed by your work (especially scientific part), so I decided to help you with the industrial part.

Phaze#1 done in #81
Phaze#2 should be related to the issues found by detekt
Phaze#3 Kdocs and other related things

  • 🚀1
orchestr7 commented

@nbirillo could you please link my PRs to this issue, I don't have an access :(
And ping me, please, when you will merge everything and I will be able to continue with detekt

  • 👍1
elena-lyulina commented

@akuleshov7 thanks a lot for your help :)
I have merged everything into the master branch.
detekt gradle task is commented out for now, it would be great if you could continue working on it

orchestr7 commented

@elena-lyulina hi, Lena, I will finish the detekt this week. Detekt automated estimations on fixing everything was more than 24 hours when I was running it 😂

UPD 28/11: still in progress

  • 😄1
  • 👀1
orchestr7 commented

@elena-lyulina @nbirillo pls check and link the following PR to this issue: #85

What's left:

  • diktat 1.0.0 was released, it's time to a final migration to a stable major release
  • add badges to the readme to make docs more pretty

Will make it in the next PR

  • 👍1