Repro of DEXP-576424

Question

Repro of DEXP-576424

NinoFloris opened this issue 4 years ago · 12 comments

Notice specifically Sdk="Microsoft.NET.Sdk.Web" which enables the mvc analyzer.

The analyzer seems to unconditionally run for every referenced method once any project in the project graph enables this analyzer. In our large solution we only have one Sdk.Web project which is not depended on, instead it only depends on projects (one of these projects contains the full version of the following repro).

Once the mvc analyzer is loaded opening any file that transitively depends on the file that contains this code pattern will trigger the exception through the mvc analyzer, every time such a file is opened.

Quite surprising to see it runs over all of that code.

Repro:

Project file:

<Project Sdk="Microsoft.NET.Sdk.Web">

<PropertyGroup>
    <TargetFramework>net5.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <Compile Include="Library.fs"/>
  </ItemGroup>

</Project>

Then a very F# specific code pattern triggers the error, two extension methods where one method refers to a static extension method.

Library.fs:

namespace ClassLibrary1

type M() = class end

// both need to be extension methods, and the called method must be static 
module Ext =
    type M with
        // must take an argument
        static member First(x: obj) = ()
        // must call First
        member _.Second() = M.First null

Answer 1 · 2021-03-14T14:13:32.000Z

@NinoFloris Thanks for the detailed repro, I've already fixed the exception itself. I'm going to look what could be done about the analyzer too.

The analyzer seems to unconditionally run for every referenced method once any project in the project graph enables this analyzer. In our large solution we only have one Sdk.Web project which is not depended on, instead it only depends on projects (one of these projects contains the full version of the following repro).

So, if project B is an Sdk.Web project and references project A, it'll also throw when opening files from A?

Answer 2 · 2021-03-14T14:17:24.000Z

Correct, probably because you could move your mvc models to a shared core lib and still want those to be recognized. However for F# projects I can't remember ever seeing this analyzer showing me additional info/actions. (Yet apparently it runs anyway)

Answer 3 · 2021-03-19T16:16:17.000Z

Did 5931ed5 make it into EAP 8? I expect not as I still see the error pop up quite often. @auduchinok do you know when it will drop?

Answer 4 · 2021-03-27T18:16:15.000Z

With EAP 9 Beta https://youtrack.jetbrains.com/issue/DEXP-584389

Answer 5 · 2021-03-27T20:52:32.000Z

Oh, that's another one. Thanks @NinoFloris!

Answer 6 · 2021-04-07T15:38:28.000Z

@auduchinok it's still there in EAP 10, I guess the issue will make it into the release build?

Answer 7 · 2021-04-07T15:40:26.000Z

I think https://youtrack.jetbrains.com/issue/RIDER-60765 and https://youtrack.jetbrains.com/issue/DEXP-577741 (which I just reported) are both related, not sure if you got to either by any chance.

Answer 8 · 2021-06-03T13:18:34.000Z

Another one, this plugin is driving me crazy.
https://youtrack.jetbrains.com/issue/DEXP-561480

@auduchinok any way of disabling it?

Answer 9 · 2021-06-03T13:56:16.000Z

I think https://youtrack.jetbrains.com/issue/RIDER-60765 and https://youtrack.jetbrains.com/issue/DEXP-577741 (which I just reported) are both related, not sure if you got to either by any chance.

@NinoFloris I've these two exceptions yesterday, looking at the others now.

@auduchinok any way of disabling it?

Sorry, nothing I could suggest. Hopefully it'll be fixed soon, and I'll be able to issue a plugin update.

Answer 10 · 2021-06-03T15:01:15.000Z

I've just fixed the rest of the exceptions. We've also chatted with R# team about this analyzer, and it'll be turned off until we properly implement some missing pieces for F#.

Answer 11 · 2021-06-03T15:02:33.000Z

Thanks again for reporting it!

Answer 12 · 2021-06-04T18:29:05.000Z

Thanks a lot @auduchinok :) looking forward to the next eap