Extract Android permissions from HomeActivity
Opened this issue · 0 comments
JoaquimLey commented
HomeActivity
is currently responsible for requesting the necessary Android permissions, this is wrong.
Context
The idea is the HomeActivity
should only be responsible for navigation.
Tasks
- Create a specific activity to request the permissions (since the app is unusable without), keeps the responsibilities simple.
Extract this code from HomeActivity
/**
* Runtime permission shenanigans
*/
private fun hasReadSmsPermission(): Boolean {
return ContextCompat.checkSelfPermission(this, Manifest.permission.READ_SMS) == PackageManager.PERMISSION_GRANTED &&
ContextCompat.checkSelfPermission(this, Manifest.permission.RECEIVE_SMS) == PackageManager.PERMISSION_GRANTED &&
ContextCompat.checkSelfPermission(this, Manifest.permission.SEND_SMS) == PackageManager.PERMISSION_GRANTED
}
private fun requestReadAndSendSmsPermission() {
ActivityCompat.requestPermissions(this,
arrayOf(Manifest.permission.SEND_SMS, Manifest.permission.READ_SMS, Manifest.permission.RECEIVE_SMS), SMS_PERMISSION_CODE)
}