Using PCA backgrounds in Sherpa changes the default behaviour of plots
ruizca opened this issue · 2 comments
After using the auto_background function in Sherpa, the data and fit plots use counts in the y axis. Since the default behavior of Sherpa is using count rates, this change after calculating PCA models can be quite annoying. It is something easy to fix by the user, but it can take some time to realize what happen.
As far as I understand this is caused by the following line in the fit method of the PCAFitter class:
BXA/bxa/sherpa/background/pca.py
Line 359 in 5a6ee5f
It would be helpful if a note is included in the documentation so the users are aware of that change when using PCA models.
Ideally, the best would be to recover the initial behavior of Sherpa after running a PCA fit. I can give it a try, if you think is something worth it.
Yes, that sounds like a good idea. IIRC one also should not set any energy limits yet at that point.
I added a line at https://johannesbuchner.github.io/BXA/pca-background-models.html