JohnEarnest/Decker

Saving (locally?) is broken

necrophcodr opened this issue · 4 comments

necrophcodr commented

When saving a deck as an HTML file via the web-decker system, it doesn't open properly again. The screen is left blank, and it appears to throw errors in the console as follows:

Uncaught TypeError: q(...) is null

Reproduction is relatively straight forward:

  1. Go to https://beyondloom.com/decker/tour.html
  2. Save deck as HTML
  3. Open locally saved HTML deck
  4. Save deck as HTML again
  5. Open newly saved HTML deck

I'm not certain why this happens, but it appears that it is NOT the intention for this to happen.

necrophcodr commented

Some additional information regarding the platform it was tested on:
Browser: Firefox 107.0.1
OS: NixOS 22.05 64bit

JohnEarnest commented

I believe I have identified and corrected this issue.

necrophcodr commented

I believe I have identified and corrected this issue.

Indeed! I've tested the commit before that and that commit as well, and your fix resolves the issue entirely for me. Thank you so much for putting time into this wonderful project!

  • 👍1
JohnEarnest commented

Thanks for the bug report!