EntityRuler fails two basic tests
jfernandrezj opened this issue · 4 comments
Is there an existing issue for this?
- I have searched the existing issues and did not find a match.
Who can help?
What are you working on?
Matching Keyword Patterns from a list of known keywords
Current Behavior
Both current behavior and desired behavior is documented in the branch with the failing tests:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests
Expected Behavior
Both current behavior and desired behavior is documented in the branch with the failing tests:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests
Steps To Reproduce
Just run the added tests in the branch:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests
Spark NLP version and Apache Spark
Spark 3.4
Spark NLP 5.2.2
Type of Spark Application
No response
Java Version
Java 11
Java Home Directory
No response
Setup and installation
No response
Operating System and Version
No response
Link to your project (if available)
No response
Additional Information
No response
@jfernandrezj do you have a PR/fix for this issue?
A branch containing a potential fix for this issue is in:
https://github.com/JohnSnowLabs/spark-nlp/tree/issues/aho-corasick-failing-tests-fix-for-discussion
Please check it out and I can create a PR once we are ok
LGFM I think you can create a PR for this
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 5 days