table border missing after image are loaded in table

Question

table border missing after image are loaded in table

Opened this issue 6 years ago · 10 comments

Hi,

Could you help me to solve this issue as when i add image in the table all border and table color are missing.

Answer 1 · 2018-05-30T17:19:59.000Z

Do you mean that when you add an image, all of the custom background colors and borders disappear? Interesting, do you have a console error log or possibly steps to reproduce this bug?

Thanks
JT

Answer 2 · 2018-05-31T01:17:00.000Z

Hi, After done few testing I realised that the bug happened as JTRT css reset to default after clashing with others plugin. Now I have manually added css in the WordPress. When the page is empty the table have no error but when added few other info at will cause this problem. Here are the error taken from my browser. Uncaught SyntaxError: Unexpected token _ in JSON at position 57 at JSON.parse (<anonymous>) at HTMLTableElement.<anonymous> (jtrt-responsive-tables-public.js?ver=4.0:39) at Function.each (jquery.js?ver=1.12.4:2) at a.fn.init.each (jquery.js?ver=1.12.4:2) at HTMLDocument.<anonymous> (jtrt-responsive-tables-public.js?ver=4.0:35) at i (jquery.js?ver=1.12.4:2) at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4:2) at Function.ready (jquery.js?ver=1.12.4:2) at HTMLDocument.K (jquery.js?ver=1.12.4:2) First error at HTMLTableElement.<anonymous> (jtrt-responsive-tables-public.js?ver=4.0:39) jtrt_tables.each(function(element) { var table = $(jtrt_tables[element]); var id = table.attr('data-jtrt-table-id'); var jtrt_table_data = JSON.parse($('textarea#jtrt_table_settings_'+id).html()); if(jtrt_table_data[3] != undefined){ jtrt_table_data[3].forEach(function(element, indx1) { var tRow = table.find('tr').eq(element['row']); var tCell = tRow.find('td,th').eq(element['col']); tCell.html(element['val']); }); } Second error at HTMLDocument.<anonymous> (jtrt-responsive-tables-public.js?ver=4.0:35) jtrt_tables.each(function(element) { var table = $(jtrt_tables[element]); var id = table.attr('data-jtrt-table-id'); var jtrt_table_data = JSON.parse($('textarea#jtrt_table_settings_'+id).html()); if(jtrt_table_data[3] != undefined){ jtrt_table_data[3].forEach(function(element, indx1) { var tRow = table.find('tr').eq(element['row']); var tCell = tRow.find('td,th').eq(element['col']); tCell.html(element['val']); }); } Please do inform me if you want more information as i can see this table have a lot of potential just need to settle minor bug in the code. Regards,Tariq Arif Sent from Yahoo Mail on Android On Thu, 31 May 2018 at 1:20 am, John Tendik<notifications@github.com> wrote: Do you mean that when you add an image, all of the custom background colors and borders disappear? Interesting, do you have a console error log or possibly steps to reproduce this bug? Thanks JT — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Answer 3 · 2018-06-21T04:58:38.000Z

I wanted to post about this issue and saw that someone else has already raised it here. John, please do something about this. A stitch in time.....

Answer 4 · 2018-06-21T05:05:35.000Z

To reproduce the problem, simply create a new table. Add some text and then go on to add at least an image in one of the cells. Save and try to view the table. You will notice that it displays without borders. However, when you remove the image and left only the text in the table, the borders appear.

Thank you.

Answer 5 · 2018-06-22T14:29:13.000Z

I will take a look at this tonight. I apologize for lack of updates, time has been a precious resource lately :D

Answer 6 · 2018-06-24T05:12:50.000Z

@JohnTendik Thanks a lot bro.

Answer 7 · 2018-06-29T02:39:12.000Z

@Seamate I am unable to reproduce this issue, can you provide some more info if possible?

I tried the following steps to try and reproduce:

create new table
add borders
add text
add image
save

As @mtba85 stated, it could be some other plugin interfering with the styles.

Answer 8 · 2018-06-29T03:03:30.000Z

Interestingly, I also discovered that the borders reappeared suddenly. I don't know which plugin caused the conflict.
However, if I try to INSERT images, it gets stuck on "Doing calculations. Please wait.." Hence, what I do to add images to the table is to copy the image's url and paste it in the table while wrapping it in the tag.

Please see if you can reproduce this problem. It could be linked to the plugin dispute.
Thank you, John, for your time.

Answer 9 · 2018-06-29T03:21:38.000Z

@Seamate good to hear the borders are back, it sounds like another plugin is interfering with the border styles. I technically could add !important on all of my styles haha but I'm pretty sure everyone would hate me.

As for the image upload issue, I just released an update that fixed the broken image uploader. Please let me know if you still run into issues after the update :)

Thanks

Answer 10 · 2018-06-29T04:11:29.000Z

Thanks bro. I didn't know an update would be released so quickly. I wanted to ask if you could make it possible to search for tables using the table shortcode. It is much easier to locate tables that way if they run into hundreds or thousands. At the moment, it is only possible to search with the title of the table.
Please consider this in future releases.

Thanks for fixing the image insert issue. Also, the tables area jumping issue seems to have been fixed with the update. Very cool