Crash when opening sub tasks

[emilyselwood]

Describe the bug
Expanding a todo list entry with a reasonable number of tasks crashes

Factorio version: 0.18.9 build 49691 win64

To Reproduce
Steps to reproduce the behavior:

1. Open todo list
2. Click on Details for a task that has sub tasks (a task without subtasks opens ok)
3. See error at end of bug report.

Expected behavior
A clear and concise description of what you expected to happen.
Expected task list to show sub tasks.

Screenshots
If applicable, add screenshots to help explain your problem.

Error message shown below:

The mod Todo List (18.0.0) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event Todo-List::on_gui_click (ID 1)
Unknown sprite "utility/remove"
stack traceback:
Todo-List/todo/ui/main_frame.lua:429: in function 'add_row_to_main_table'
Todo-List/todo/ui/main_frame.lua:399: in function 'add_subtask_to_main_table'
Todo-List/todo/ui/main_frame.lua:312: in function 'add_subtasks_to_task_table'
Todo-List/todo/ui/main_frame.lua:295: in function 'add_task_to_table'
Todo-List/todo/features/main_ui.lua:71: in function 'refresh_task_table'
Todo-List/todo/features/details_view.lua:10: in function 'on_show_task_details_click'
Todo-List/todo/todo.lua:145: in function 'on_gui_click'
Todo-List/control.lua:20: in function <Todo-List/control.lua:19>
stack traceback:
[C]: in function 'add'
Todo-List/todo/ui/main_frame.lua:429: in function 'add_row_to_main_table'
Todo-List/todo/ui/main_frame.lua:399: in function 'add_subtask_to_main_table'
Todo-List/todo/ui/main_frame.lua:312: in function 'add_subtasks_to_task_table'
Todo-List/todo/ui/main_frame.lua:295: in function 'add_task_to_table'
Todo-List/todo/features/main_ui.lua:71: in function 'refresh_task_table'
Todo-List/todo/features/details_view.lua:10: in function 'on_show_task_details_click'
Todo-List/todo/todo.lua:145: in function 'on_gui_click'
Todo-List/control.lua:20: in function <Todo-List/control.lua:19>

[emilyselwood]

I've attached the save file at the point this happens
_autosave1.zip

The following mods are in use:

• LogisticTrainNetwork 1.12.1
• OpteraLib 0.2.0
• Power Armor Mk3 0.2.13
• Squeak Through 1.8.0
• Todo-List 18.0.0
• Waterfill_v17 0.18.0
• base 0.18.9

[JonasJurczok]

Hey, thanks for the detailed report. The root cause is that apparently some icons from the base game got renamed. The fix should be easy (have proper local icons). Unfortunately I'm currently moving flats and won't have a working computer until Friday (hopefully). Until then you can either stop using sub tasks or remove the icon from the configuration. Both workarounds are not really durable, sorry :/

[emilyselwood]

Fair enough. At least it is not something I've done to break it. Good luck with the move.

[Dilise]

Hi, I corrected the error of the missing sprite. Issued a pull request. New sprite-utility/trash_bin.

[Dilise]

I found another flat picture of the trash:

This sprite is better. Made a new commit.
Name of the sprite in the utility module:

PS: Factorio version 0.18.10 x64

[JonasJurczok]

A new version has been released. Thank you very much for the help and patience.

I'm leaving this open for a couple days to check if it is actually fixed :)

[emilyselwood]

Seems fixed on mine. Thanks @JonasJurczok and @Dilise

[JonasJurczok]

Awesome :)