Time of disposal after swipe depends on where it is released
InfiniteTabs opened this issue · 2 comments
Hi!
First of all, great work with this package!
I have experienced that the disposal has a long delay before being disposed which seems to be related to where it was released on the x-axis. The typical use case is that the user will swipe to dismiss it, but if they are too fast trying to opening another page nothing happens (since it has not been disposed yet).
I tried to demonstrate it here: https://vimeo.com/517835528
As seen in the video it is first released near to the right => it gets disposed immediately according to the log.
The second time the page is swiped and released far to the left => according to the log it gets disposed with a delay after it has disappeared.
Best regards
Thanks for the detailed description and even a video! SwipeablePageRoute
actually inherits from Flutter's built-in CupertinoPageRoute
(well, before v0.2.0 it just copied the code) and only adds parameters to control from where the back gesture can start. It seems like this problem is reproducible with CupertinoPageRoute
, so I recommend filing an issue there.
Thanks for the reply, I had no idea it was a problem with the built in code.
I've continued the discussion here: flutter/flutter#73026