JorikSchellekens/lyricist

Fix metadata extraction from the title

Closed this issue · 4 comments

The current way of extracting the artist name and the song title do not account for the the fact that the song title can have dashes in it.

Example Kasabian - Re-wired, with the current approach the the metadata object looks like :-

{
  artist: 'Kasabian - Re',
  title: 'wired',
}

I have a proposal for fixing this issue, would appreciate your comments/thoughts @JorikSchellekens.

I've left some comments on the Gist. Small edits to the proposal but basically the second solution seems the best.

Will you PR?

Yeah I have the PR ready I'll just polish it a bit.