JoryHogeveen/off-canvas-sidebars

Add nofollow to OCS tigger links

inspiredearth opened this issue · 2 comments

Description

Describe the solution you'd like
I would like to suggest adding either rel="nofollow" or data-nofollow to the trigger links. Without these, Google's SEO analysis for the site will deduct a few points due to there being links without a valid href. As shown here:

image

Is your feature request related to a problem? Please describe.
The issue is that Google's PageSpeed and SEO analysis doesn't like links without an href attribute. It might have minimal real world impact, but since the solution is so simple, and it will stop Google deducting a few percentage of SEO score, it might as well be implemented.

Hi @inspiredearth

By default the plugin triggers are rendered as a button. If you need an element you can use attr to add extra attributes to your links.

Example:
[ocs_trigger element="a" attr="rel: nofollow"]

As the trigger render is the same for any element what would possible issues be with other elements if I add the rel tag?
Or is the data-nofollow tag 100% sufficient?

Cheers, Jory

Fixed in 0.5.8