JoryHogeveen/off-canvas-sidebars

ocs-site white space

overcatbe opened this issue · 7 comments

overcatbe commented

Describe the bug

White space after content.
Firstly - very much thank you for this awesome plugin. :)

Steps to reproduce the behavior:

All time white space after content with fixed height as described here adchsm/Slidebars#10

Specifications

  • Plugin Version: newest
  • WordPress Version: newest
  • Other plugins installed:
  • Theme: storefront
  • Browser: all of them
JoryHogeveen commented

Hi @overcatbe,

Can you share a link so I can take a look at you site structure and CSS?

Thanks, Jory

overcatbe commented

it's a site in making so ugly as of now :)
https://www.croatian-apartments.com/?page_id=180
thanks!

overcatbe commented

the trigger shows on mobile width. :D

JoryHogeveen commented

Hi @overcatbe,

It seems your structure is incorrect.
You current HTML shows this:

<body>
   <div id="page">
      Site content
   </div>
   <div id="ocs-site">
      Canvas container
   </div>
</body>

While it should show this:

<body>
   <div id="ocs-site">
      <div id="page">
         Site content
      </div>
   </div>
</body>

Please check if your installation is using the correct hooks and the hooks are placed correctly.
See: installation guide

Let me know! Jory

JoryHogeveen commented

Oh, since you are using Storefront, see this page for compatible hooks:
https://github.com/JoryHogeveen/off-canvas-sidebars/wiki/Compatible-theme-hooks#storefront-woocommerce

Keep in mind though that the wp_footer hook is not officially supported yet, it's in development here:
PR v0.5.3: #58

overcatbe commented

indeed! i need to learn to read! thanks!

JoryHogeveen commented

No problem! If you run into any problems let me know!

PS: if you like the plugin, please consider leaving a nice review, it will help the plugin grow
https://wordpress.org/support/plugin/off-canvas-sidebars/reviews/#new-post

  • 🎉1