JoshGlazebrook/socks

Reuse Socks options between connections

yciabaud opened this issue · 1 comments

Hello,

I am using this module in webtorrent/webtorrent#874 and I have an issue using multiple connections at the same time.

It looks like modifying the options properties conflicts with the other instances of the module. We have to clone it before passing it to the module.

Please have a look at webtorrent/webtorrent#874 (comment) for reference.

I believe the options should be cloned or not modified to avoid bugs. What do you think?

V2 is now published and available. This issue is definitely fixed.