JsonApiClient/json_api_client

Implementation of `inherited` method doesn't call `super`

mqchau opened this issue · 0 comments

Version 1.16 of this gem introduces a new method inherited here

subclass._immutable = false

All implementation of inherited that I have seen so far calls super in them so that the parents' implementation of inherited are called.

Examples:
https://github.com/rails/rails/blob/02ecdf61d151ec3c852585c93942d0ea2ed2bd22/activesupport/lib/active_support/descendants_tracker.rb#L56
https://github.com/rails/rails/blob/affa3f8661fa916c4e80f9a68be16ba877ada3a8/actionpack/lib/action_controller/metal/rendering.rb#L23
https://github.com/rails/rails/blob/6d37c6c41a808d0f52b110d9bc1c71af8201900e/activesupport/lib/active_support/execution_wrapper.rb#L99

I will make a PR soon to add super to method inherited in that file.