JujaLabs/teams-slack-bot

Refactor properties to use full url in endpoints

Closed this issue · 0 comments

Use full url in endpoints

teams.slackbot.rest.api.version=v1
teams.slackbot.commandsUrl=/commands
teams.slackbot.endpoint.activateTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams/activate
teams.slackbot.endpoint.deactivateTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams/deactivate
teams.slackbot.endpoint.getTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams
teams.slackbot.endpoint.getMyTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/myteam

instead

teams.slackbot.commandsUrl=/commands
teams.slackbot.rest.api.version=v1
teams.slackbot.endpoint.activateTeam=/teams/activate
teams.slackbot.endpoint.deactivateTeam=/teams/deactivate
teams.slackbot.endpoint.getTeam=/teams
teams.slackbot.endpoint.getMyTeam=/myteam
teams.slackbot.endpoint.heartBeat=/heart

refactor controller/repositories methods mapping and tests