Query on :discrete_to_continuous autotypes option
Closed this issue · 1 comments
ablaom commented
From the doc string:
Note that it doesn't touch features already marked as `Finite`.
But Finite
is not tested in the code:
function discrete_to_continuous(type::Type, _, _)
nonmissing(type) <: Union{Count,Integer} && return T_or_Union_Missing_T(type, Continuous)
return type
end
Under the convention mlj
this won't matter, but under any other convention it might, no?
tlienart commented
Yes nice, I'll fix the doc to clarify what it does exactly.