Redundant calling of bbox for circular aperture
Closed this issue · 2 comments
siddharthlal25 commented
Photometry.jl/src/Aperture/circular.jl
Line 44 in 46d4a6c
Line number 43: creating bounds by calling edges, and edges call bbox internally.
Line number 44: creating a bounding box by calling bbox
Line number 45: getting size, size calls bbox internally
Line number 46: calling circular_overlap but there is no use of the variable created in line 44, because it is not being passed as an argument.
Similarly at
Photometry.jl/src/Aperture/circular.jl
Line 90 in 46d4a6c
siddharthlal25 commented
Update: When locally tested all the tests pass without line 44 and line 90
mileslucas commented
Closed via #7