ucfirst depreciated
TeroFrondelius opened this issue · 4 comments
TeroFrondelius commented
┌ Info: Number of nodes: 3724.
│ "Number of dofs/node: $(ndofs). " = "Number of dofs/node: 3. "
└ "Dimension of geometry: $(ndim)." = "Dimension of geometry: 3."
ERROR: LoadError: UndefVarError: ucfirst not defined
Stacktrace:
[1] macro expansion at .\logging.jl:313 [inlined]
[2] macro expansion at .\logging.jl:307 [inlined]
[3] update_xdmf!(::Analysis{Modal}) at C:\Users\tfr004\.julia\packages\JuliaFEM\or1RT\src\solvers_modal.jl:226
[4] macro expansion at .\logging.jl:310 [inlined]
[5] macro expansion at C:\Users\tfr004\.julia\packages\TimerOutputs\sc5fl\src\TimerOutput.jl:184 [inlined]
[6] macro expansion at .\logging.jl:307 [inlined]
[7] run!(::Analysis{Modal}) at C:\Users\tfr004\.julia\packages\JuliaFEM\or1RT\src\solvers_modal.jl:98
[8] macro expansion at .\logging.jl:308 [inlined]
[9] (::Analysis{Modal})(::Float64) at C:\Users\tfr004\.julia\packages\JuliaFEM\or1RT\src\solvers.jl:678 (repeats 2 times)
[10] top-level scope at none:0
[11] include at .\boot.jl:317 [inlined]
[12] include_relative(::Module, ::String) at .\loading.jl:1038
[13] include(::Module, ::String) at .\sysimg.jl:29
[14] include(::String) at .\client.jl:388
[15] top-level scope at none:0
in expression starting at C:\Data\multiaxialfatiguetestspecimen\run_juliafem.jl:74
julia>Here is the depreciation warning from 0.7:
julia> ucfirst("not working")
┌ Warning: `ucfirst` is deprecated, use `uppercasefirst` instead.
│ caller = top-level scope at none:0
└ @ Core none:0
"Not working"
julia>And here is the problem line: https://github.com/JuliaFEM/JuliaFEM.jl/search?q=ucfirst&unscoped_q=ucfirst
TeroFrondelius commented
One thing to add: before fixing this issue one should add a test that raises this issue. I think we have a cap in testing somehow.
jounihuo commented
Faced the same issue with 'ucfirst', could 'titlecase' be used instead?
TeroFrondelius commented
@jounihuo possibly. I would just still use uppercasefirst as the deprecation warning proposess. Please follow these instructions: http://www.juliafem.org/contributing/, to open a pull request.