lgamma is deprecated to logabsgamma
aminya opened this issue · 3 comments
aminya commented
In the Julia 1 branch (#17) or once it is merged,
we should address this.
https://github.com/JuliaMath/SpecialFunctions.jl/blob/master/src/deprecated.jl#L1
Crown421 commented
I am not sure how we would do that?
The function that VML provides is lgamma and I don't see nice way and a good reason to force some VML.logabsgamma(a)[1] syntax.
What should be changed is the use of Base.lgamma in the tests, which might require special treatment.
aminya commented
Maybe we can just wrap VML.lgamma in some function to provide VML.logabsgamma(a)[1]
We can have both. There is no reason to deprecate lgamma