JuliaPackaging/JLLWrappers.jl

confusing deprecation messaging

Opened this issue · 0 comments

The depwarn created here creates a log message with a malformed location

Base.depwarn(string($(product_name), "() is deprecated, use the non-do-block form"), $(string(product_name)))

┌ Warning: ffmpeg() is deprecated, use the non-do-block form
│   caller = ip:0x0
└ @ Core :-1

Also, perhaps the message should say Warning: using executables via a function return like ffmpeg() is deprecated by JLLWrappers, use the non-do-block form

Even with --depwarn=error it appears to be coming from FFMPEG_jll but the src is JLLWrappers

julia> FFMPEG.exe("-v")
ERROR: ffmpeg() is deprecated, use the non-do-block form
Stacktrace:
 [1] depwarn(msg::String, funcsym::String; force::Bool)
   @ Base ./deprecated.jl:124
 [2] depwarn(msg::String, funcsym::String)
   @ Base ./deprecated.jl:121
 [3] ffmpeg(f::Function; adjust_PATH::Bool, adjust_LIBPATH::Bool)
   @ FFMPEG_jll ~/.julia/packages/JLLWrappers/pG9bm/src/products/executable_generators.jl:20
 [4] ffmpeg(f::Function)
   @ FFMPEG_jll ~/.julia/packages/JLLWrappers/pG9bm/src/products/executable_generators.jl:19
 [5] #exe#2
   @ ~/.julia/packages/FFMPEG/OUpap/src/FFMPEG.jl:0 [inlined]
 [6] exe(args::String; command::Function, collect::Bool)
   @ FFMPEG ~/.julia/packages/FFMPEG/OUpap/src/FFMPEG.jl:64
 [7] top-level scope
   @ REPL[9]:1