missing arguments in rand! methods for StaticArrays
Closed this issue · 3 comments
schrimpf commented
The rand! methods for StaticArrays beginning on line 398 of api.jl don't define α, β, and γ, but use them in the call to samplevector!.
chriselrod commented
That's a definite bug.
Would you be willing to make a PR fixing that and adding tests by any chance?
schrimpf commented
Sure.
chriselrod commented
If you're feeling particularly ambitious, you could also turn the StaticArraysCore dependency into a weakdep/PkgExtension, so that it only gets loaded when someone is actually using StaticArrays.
https://julialang.org/blog/2023/04/julia-1.9-highlights/#package_extensions
But absolutely no pressure, any contributions welcome. I don't like letting the desire for immediate perfection be the enemy of progress.