JuliaServices/Match.jl

use `false` instead of `Symbol(false)`

JeffBezanson opened this issue · 5 comments

JeffBezanson commented

See JuliaLang/julia#34077 (comment)

Symbols named false used to round-trip incorrectly; they would be converted to Bool at some point. This is now fixed. false can be placed in an AST directly; it doesn't need to be a Symbol.

kmsquire commented

What version of Julia should changing this require?

JeffBezanson commented

Replacing Symbol(false) with false should work on all versions.

vtjnash commented

Presumably this is why PkgEval is failing:

Error During Test at /home/pkgeval/.julia/packages/Match/qiTCM/test/matchtests.jl:303
  Test threw exception
  Expression: balance(Black(1, Red(2, Red(3, Leaf(), Leaf()), Leaf()), Leaf())) == Red(2, Black(3, Leaf(), Leaf()), Black(1, Leaf(), Leaf()))
  UndefVarError: false not defined
  Stacktrace:
   [1] balance(tree::Black)
     @ Main ~/.julia/packages/Match/qiTCM/test/matchtests.jl:294
kmsquire commented

Sorry, I forgot all about this.