check if focusutils.js works on remote machine
aviatesk opened this issue · 2 comments
aviatesk commented
I found in julia-client we don't use ink.Opener.open
's remote
option at all.
Fortunately we only have one single feature who consumes ink.Opener.onDidOpen
emission:
focusutils.js
https://github.com/JunoLab/atom-julia-client/blob/master/lib/ui/focusutils.js#L69-L71
But obviously it's better to be fixed. I guess just using allowremote
global instead of remote
optional argument might be enough, but not sure.
What do you think on this @pfitzseb ?
pfitzseb commented
I'm 99% sure the remote
option is completely unused and could be safely removed.
aviatesk commented
ah yeah I double checked just now, and it's certainly unused anymore.