Using pipenv for deps managment
Closed this issue · 3 comments
Hey @kbondarev,
Would you be open to possibly using pipenv vs just regular pip + freezing deps?
Similar to here where I made the case of using pipenv it's a lot easier way to manage your dependencies, and can add all your development dependencies in there as well (if you using pylint + black (or whatever linting + formatter you use)).
The other great thing you get out of using that is the inherit "freeze" via a .lock file, and it allows you to more easily upgrade things as well (via the pipenv update command (or via this)). It'll automatically handle setting up a virtual environment as well, or you can still have a local venv.
I've used it in GH actions before (thinkin about the JB website), so it works pretty well and even has a native GH action caching as well.
I'd happily make a PR to implement these changes (to both this repo + the main JB repo), but I just wanted to see what you thought about it first before doing that work 😅.
Good pipenv resources:
- Video by author at pycon 2018 (author or the requests package)
- Really comprehensive guide to pipenv
- Using in GH actions (ex1 & ex2) (one of my projects)
- docs
That's a good idea! Caching would reduce the time of the GH scraping action a little.
Personally, I'm a little bit more familiar with poetry. So naturally I'd prefer to use it instead of pipenv. But in the end I wouldn't mind pinenv either.
So... go ahead and setup either :)
Yay 😁 , ya I've heard of poetry before and I've heard it's really good whenever you want to publish a package to pypi or any other python packaging place. (although I'm not super familiar with it to be honest)
Awesome, I'll get that taken care of then 😁 🚀
closed by #19