error when using `svd` with truncation

Question

error when using `svd` with truncation

Closed this issue 5 years ago · 4 comments

It seems that SVD with truncation is broken due to changes in the iterator interface in Julia.
Specifically in _truncate! there are calls to start, next and done which do not exist anymore (Julia v1.2). As far as I understand all of these were replaced by iterate.

Here is a MWE

S = U₁Space(n=>1 for n in 1:10)
M = TensorMap(rand,Float64, S, S)
svd(M; trunc=truncerr(1e-10))

I might try to fix this myself at some point in case you don't get to it before I have time for that (but at the moment I have to go do other work).

Answer 1 · 2019-09-18T09:47:39.000Z

Ok, clearly another gap in my set of tests. I'll fix it right away

Answer 2 · 2019-09-18T19:36:38.000Z

Fixed on master and added test to prevent failures in the future; awaiting CI but it is looking good. Will tag a new version thereafter.

Answer 3 · 2019-09-18T20:27:52.000Z

Thanks for the quick fix!

Answer 4 · 2019-09-19T06:33:55.000Z

Can confirm that this is working now, so I will go ahead and close this issue.