KSP-RO/DeadlyReentry

NullReferenceException in DeadlyReentry.ModuleAeroReentry.IsShielded

jakkarth opened this issue · 6 comments

jakkarth commented

Using 4.8 on 64bit 0.24 on Linux, I am receiving errors in my log when using deadly reentry parts.

Excerpt from log:

NullReferenceException: Object reference not set to an instance of an object
at DeadlyReentry.ModuleAeroReentry.IsShielded (Vector3 direction) [0x00000] in :0
at DeadlyReentry.ModuleAeroReentry.ReentryHeat (Vector3 velocity) [0x00000] in :0
at DeadlyReentry.ModuleAeroReentry.FixedUpdate () [0x00000] in :0

Also, sometimes I get weird puffs of smoke coming out of the DR decouplers/heatshields (not sure which, but definitely localized there).

Running Deadly Reentry Continued 4.8 (md5: def800ac5b88c04de79055a27c7c2368) with latest Firespitter (from Github, no version info in filename, md5: 69b343dac2eb26ab161638fff4415566).

Any other information I can provide, please ask.

Thanks for an awesome mod! 0.24 just wasn't the same without it so I'm super glad you updated!

jakkarth commented

It seems to have something to do with my airspeed. When I launch from the launchpad, everything's fine, but the lines start appearing when my airspeed exceeds about 250m/s. If I cut throttle and slow due to gravity/drag a bit, the errors stop, then I resume throttle and when I exceed about 250m/s the lines start again. It's hard to tell exactly what speed triggers it.

They also stop when I pass 69km altitude over Kerbin.

NathanKell commented

Ok. Please include the complete output log, and reproduction steps (every time every craft when above 250m/s? Because that doesn't happen for me. Need more details.)

jakkarth commented

It is not every spacecraft. I've been trying to find a minimum reproducible craft to demonstrate the problem. I can't attach a zipfile with the logs, so visit http://silenttosaturn.com/DRC48log.zip to get the Player.log, KSP.log and the craft file. Note that there is no heatshield part in my current reproduction case, just the decoupler.

Steps to reproduce:

  1. Install DRC4.8, RealChute1.2, FAR0.14. Not sure whether FAR is required to reproduce this or not. I also have several other mods installed besides these. I can test with just these 3 if that would be helpful, but the others don't appear to be relevant.
  2. Open the VAB and grab a 1-seat command pod, RC nosecone on top (regular, not dual), UP13 decoupler under that, X200-32 fuel tank under that, and a skipper engine under that.
  3. Adjust staging such that the parachute and decoupler are in stage 0, engine is in stage 1.
  4. Set throttle to 100% and turn SAS on.
  5. Press space to launch.
  6. Wobble east a bit like you're doing a gravity turn (this may not be required).
  7. At 250m/s (around 1800m), log messages start.

A further test revealed the problem persists even with the decoupler removed.

jakkarth commented

Here is a shot of the craft in flight.

screenshot273

NathanKell commented

Ah! Yeah, fixed in git. Will release when I get home tonight.

jakkarth commented

You are a god among men. Hats off to you sir!