Phobos SOI too small

Question

Phobos SOI too small

Losalex42 opened this issue a year ago · 7 comments

Losalex42 commented a year ago

SOI is the same as the radius. Makes it impossible to orbit or land on.

20.0.0 KSP 1.12.3

Answer 1 · 2023-06-21T12:38:30.000Z

That certainly isn't the case on my install.

Answer 2 · 2023-06-21T13:09:46.000Z

Very strange.

Answer 3 · 2023-06-21T13:11:15.000Z

I'm going to bet that this is a conflict with some other mod and not actually an issue with RSS itself.

Answer 4 · 2023-06-21T13:39:08.000Z

I've whiped my ksp folder and reinstalled everything and using the bare minimum to get rss working. It's still an issue. I did use CKAN though.

Answer 5 · 2023-06-21T13:51:41.000Z

I downgraded to rss v19.1.0 from 20.0.0 and that fixed the issue.

Answer 6 · 2023-06-21T14:12:22.000Z

Ahh, so turns out that the install I had open at that time was running RSS v19.1. Can confirm that the issue started happening in v20 so it has to be related to #285.

Not sure why setting finalizeOrbit to false caused other side effects rather than just the orbital period changes. Maybe @R-T-B has ideas?

Answer 7 · 2023-08-26T10:07:59.000Z

From one of my comments on the issue :

I'm not entirely sure why the FinalizeOrbit() method is also recomputing the hill sphere and SOI, this seems like something that should be independent of the period / meanMotion hack, so in case setting finalizeOrbit = true also has this purpose, I would suggest gating the hack behind an additional config switch so planets configs can opt-out of it.